Use versions from grails-bom in additional locations #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamesfredley
commented
Feb 13, 2025
jamesfredley
commented
- Use versions from grails-bom in additional locations
- add grail-bom to buildscript{} to pull in versions
- put assetPipelineGradleVersion in gradle.properties
- update dependency versions not provided by grails-bom
add grail-bom to buildscript{} to pull in versions
put assetPipelineGradleVersion in gradle.properties
update dependency versions not provided by grails-bom
jdaugherty
reviewed
Feb 13, 2025
| @@ -60,6 +60,13 @@ public void apply(GeneratorContext generatorContext) { | |||
| .version("$grailsVersion") | |||
| .implementation()); | |||
|
|
|||
| generatorContext.addBuildscriptDependency(Dependency.builder() | |||
There was a problem hiding this comment.
If you're including the bom, you don't need an asset pipeline version. It's in the bom.
There was a problem hiding this comment.
For asset-pipeline we are using id to load the plugin from the Gradle plugin portal and I have not found a way to reference the grails-bom version for use with id in the plugins{} block.
jdaugherty
reviewed
Feb 13, 2025
grails-forge-core/src/main/java/org/grails/forge/feature/grails/GrailsWebConsole.java
Show resolved
Hide resolved
jdaugherty
reviewed
Feb 13, 2025
matrei
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.