-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface for depth in both forward rendering and backward propagation #3
Conversation
That's cool thank you, its a duplicate of graphdeco-inria/gaussian-splatting#20 similar things apply, to be able to accept it we either need a test for perfomance in one of the mipnerf360 scenes or tanks and temples (before and after) to make sure there is no regression or a flag that is by default disabling the depth rendering. edit: by perfomance i mean speed |
Note this is identical to #2 Even uses the same variable names... |
Hey, How can I display the depth map ? |
Hi, you can refer to #30 in gaussian-splatting |
Thanks! |
Hi, I'd like to use your code to get depth image when training (running train.py). I have successfully tested getting depth image when running render.py. |
Hi, depth backpropagation should not cause an error. I guess you might have used the wrong branch. You can refer to this PR. The depth branch contains both forward and backward propagation of depth, whereas the main branch only contains the forward propagation of depth. |
Thanks a lot, I found I forgot to convey two parameters in backward function. |
This is the visualization for depth of lego