Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for depth in both forward rendering and backward propagation #3

Closed
wants to merge 3 commits into from

Conversation

ingra14m
Copy link

@ingra14m ingra14m commented Jul 13, 2023

This is the visualization for depth of lego
00002

@grgkopanas
Copy link

grgkopanas commented Jul 13, 2023

That's cool thank you, its a duplicate of graphdeco-inria/gaussian-splatting#20 similar things apply, to be able to accept it we either need a test for perfomance in one of the mipnerf360 scenes or tanks and temples (before and after) to make sure there is no regression or a flag that is by default disabling the depth rendering.

edit: by perfomance i mean speed

@JonathonLuiten
Copy link

Note this is identical to #2

Even uses the same variable names...
Also, doesn't actually do the backward pass properly?
Probably close as duplicate?

@ingra14m ingra14m closed this Jul 14, 2023
@dongshengLiu
Copy link

Hey, How can I display the depth map ?

@ingra14m
Copy link
Author

ingra14m commented Aug 2, 2023

Hi, you can refer to #30 in gaussian-splatting

@dongshengLiu
Copy link

Hi, you can refer to #30 in gaussian-splatting

Thanks!

@ThePassedWind
Copy link

Hi, I'd like to use your code to get depth image when training (running train.py).
However, an error occurred:
Traceback (most recent call last):
File "D:\PythonWorkplace\gaussian-splatting\train.py", line 227, in training(lp.extract(args), op.extract(args), pp.extract(args), args.test_iterations, args.save_iterations, args.checkpoint_iterations, args.start_checkpoint, args.debug_from)
File "D:\PythonWorkplace\gaussian-splatting\train.py", line 101, in training loss.backward()
File "D:\CodingSoftware\Anaconda\envs\ro_gaussian_splatting\lib\site-packages\torch_tensor.py", line 487, in backward
torch.autograd.backward(
File "D:\CodingSoftware\Anaconda\envs\ro_gaussian_splatting\lib\site-packages\torch\autograd_init_.py", line 200, in backward Variable._execution_engine.run_backward( # Calls into the C++ engine to run the backward pass
File "D:\CodingSoftware\Anaconda\envs\ro_gaussian_splatting\lib\site-packages\torch\autograd\function.py", line 275, in apply return user_fn(self, *args)
TypeError: _RasterizeGaussians.backward() takes 3 positional arguments but 4 were given
Training progress: 0%| | 0/30000 [00:00<?, ?it/s]

I have successfully tested getting depth image when running render.py.
Could you please give some suggestions about how to fix this error?

@ingra14m
Copy link
Author

ingra14m commented Dec 2, 2023

Hi, depth backpropagation should not cause an error. I guess you might have used the wrong branch. You can refer to this PR.

The depth branch contains both forward and backward propagation of depth, whereas the main branch only contains the forward propagation of depth.

@ThePassedWind
Copy link

Thanks a lot, I found I forgot to convey two parameters in backward function.
The problem is solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants