AM-4731 ext grant message #5438
Conversation
There was a problem hiding this comment.
This is not the only place where InvalidGrantException is thrown without message. Looks like there is another InvalidGrantException in package io.gravitee.am.gateway.handler.oauth2.exception. Maybe the ExtensionGrant should use the exception coming from the handler 🤔
lgw-gravitee
force-pushed
the
fix/AM-4731-ext-grant-message
branch
from
2d3410c to
ab5897a
Compare
fixes AM-4731
lgw-gravitee
force-pushed
the
fix/AM-4731-ext-grant-message
branch
from
ab5897a to
bea5257
Compare
| @@ -111,7 +111,7 @@ protected Single<TokenRequest> parseRequest(TokenRequest tokenRequest, Client cl | |||
| @Override | |||
| protected Maybe<User> resolveResourceOwner(TokenRequest tokenRequest, Client client) { | |||
| return userAuthenticationManager.loadPreAuthenticatedUser(tokenRequest.getSubject(), tokenRequest) | |||
| .onErrorResumeNext(ex -> { return Maybe.error(new InvalidGrantException()); }); | |||
| .onErrorResumeNext(ex -> Maybe.error(new InvalidGrantException(ex.getMessage()))); | |||
There was a problem hiding this comment.
question: should we test if message is null to provide generic message something like "unable to read user profile" 🤔 ?
| @@ -128,7 +128,7 @@ protected Single<TokenRequest> parseRequest(TokenRequest tokenRequest, Client cl | |||
| @Override | |||
| protected Maybe<User> resolveResourceOwner(TokenRequest tokenRequest, Client client) { | |||
| return userAuthenticationManager.loadPreAuthenticatedUser(tokenRequest.getSubject(), tokenRequest) | |||
| .onErrorResumeNext(ex -> { return Maybe.error(new InvalidGrantException()); }); | |||
| .onErrorResumeNext(ex -> Maybe.error(new InvalidGrantException(ex.getMessage()))); | |||
There was a problem hiding this comment.
question: should we test if message is null to provide generic message something like "unable to read user profile" 🤔 ?
| @@ -108,7 +108,7 @@ protected Maybe<User> resolveResourceOwner(TokenRequest tokenRequest, Client cli | |||
| } | |||
|
|
|||
| return userAuthenticationManager.loadPreAuthenticatedUser(subject, tokenRequest) | |||
| .onErrorResumeNext(ex -> { return Maybe.error(new InvalidGrantException()); }); | |||
| .onErrorResumeNext(ex -> Maybe.error(new InvalidGrantException(ex.getMessage()))); | |||
There was a problem hiding this comment.
question: should we test if message is null to provide generic message something like "unable to read user profile" 🤔 ?
|
fixes AM-4731