gppa-acf-date-formatter.php: Fixed date formatting issue caused by timezone offset resulting in a one-day discrepancy.

[malayladu]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2826054984/76967

Similar ticket: https://secure.helpscout.net/conversation/2601997622/66482

Summary

While using ACF & this snippet together resulting in a one-day discrepancy.

This issue was related to timezone.

Here's the customers screencast explains this issue.

https://video.tsttechnology.com/conversations/cf879d60-9004-5cec-99c4-0d8fde4dba88

[claygriffiths]

I like it, but I do wonder if this will create issues if the PHP timezone is set to the WP timezone instead of UTC?

I assume that the server timezone is UTC so the time coming from strtotime is also UTC. Local defaults to UTC in php.ini.hbs.

Thoughts on something like...

$timezone = new DateTimeZone( 'UTC' );

try {
    // Attempt to parse the date value
    $date = new DateTime( $template_value );
    $date->setTimezone( $timezone ); // Ensure it's parsed as UTC
    return wp_date( 'd/m/Y', $date->getTimestamp(), $timezone );
} catch (Exception $e) {
    // Handle invalid date formats gracefully
    return $template_value;
}

[malayladu]

@claygriffiths This is better implementation. It handles errors gracefully and ensures consistent behaviour.

[claygriffiths]

LGTM!