translate voltagelevel with substation creation modification label #699
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghazwarhili there was a conflict on this PR : it was simple and you were not there so I solved it myself. |
| @@ -27,6 +27,8 @@ interface ModificationValues { | |||
| energizedVoltageLevelId: string; | |||
| equipmentAttributeName: string; | |||
| equipmentAttributeValue: string; | |||
| voltageLevelEquipmentId: string; | |||
There was a problem hiding this comment.
I already said it in the back but I think equipmentId is enough and should be used for the main equipment id.
There was a problem hiding this comment.
I prefer to use voltageLevelEquipmentId to be coherent with the new VOLTAGE_LEVEL_CREATION_SUBSTATION_CREATION type
|
confirmed with @etiennehomer : no migration needed. |
…tion-voltageLevel-with-substation-creation' into implement-specific-label-translation-voltageLevel-with-substation-creation
…Level-with-substation-creation
Mathieu-Deharbe
approved these changes
Feb 26, 2025
|
ghazwarhili
deleted the
implement-specific-label-translation-voltageLevel-with-substation-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.