Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the get susceptance value per section #560

Merged

Conversation

ghazwarhili
Copy link
Contributor

No description provided.

@basseche basseche self-requested a review November 6, 2024 17:02
Copy link

sonarqubecloud bot commented Nov 7, 2024

@ghazwarhili ghazwarhili requested a review from EtienneLt November 7, 2024 10:16
@EtienneLt EtienneLt changed the title fix the get suscepatnce value per section fix the get susceptance value per section Nov 7, 2024
@@ -91,7 +91,7 @@ public static void modifyMaximumSectionCount(AttributeModification<Integer> maxi
if (maximumSectionCountModif != null) {
var maximumSectionCount = maximumSectionCountModif.getValue();
if (maxSusceptance == null && maxQAtNominalV == null) {
model.setBPerSection(model.getBPerSection() * shuntCompensator.getMaximumSectionCount() / maximumSectionCount);
model.setBPerSection((model.getBPerSection() * shuntCompensator.getMaximumSectionCount()) / maximumSectionCount);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed I think

@ghazwarhili ghazwarhili merged commit b9d16c0 into main Nov 7, 2024
3 checks passed
@ghazwarhili ghazwarhili deleted the fix-susceptance-and-qMaxAtNom-modification-by-formula-values branch November 7, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants