Send alert when some voltage levels limits are out of nominal voltage range #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… range. Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
…_send_alert Signed-off-by: FranckLecuyer <47824306+FranckLecuyer@users.noreply.github.com>
TheMaskedTurtle
requested changes
Feb 25, 2025
Comment on lines
22
to
23
| @SpringBootTest | ||
| @ContextConfiguration(classes = {VoltageInitApplication.class}) |
There was a problem hiding this comment.
No need for springboot-test it's just just classical java class testing
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
TheMaskedTurtle
requested changes
Feb 25, 2025
| /** | ||
| * @author Franck Lecuyer <franck.lecuyer at rte-france.com> | ||
| */ | ||
| @ContextConfiguration(classes = {VoltageInitApplication.class}) |
There was a problem hiding this comment.
You can also remove this one. And you should remove public keywords with junit5 for class and test method
Remove public keywords in junit test Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
TheMaskedTurtle
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for PR : powsybl/powsybl-optimizer#99
and new powsybl-optimizer release