Fix the is_run_visible calculation
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
approved these changes
Mar 4, 2025
hecrj
pushed a commit
to iced-rs/cryoglyph
that referenced
this pull request
Mar 8, 2025
* Fix the `is_run_visible` calculation * Clarify variable names in the `is_run_visible` calculation * Make the physical run_line scales `i32` instead of `f32` * Make entire `start_y_physical` expression in `is_run_visible` calculation an `i32`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fairly sure this calculation isn't correct (thought I may be wrong). If I recall correctly, the
text_areabounds are supposed to be in physical pixels, while therun_lineis in logical pixels.In a nutshell, my program had problems before this fix, now it doesn't.