Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp:Use a locally specified value instead of Segment.SIZE in okhttp #11899

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

larry-safran
Copy link
Contributor

No description provided.

@larry-safran larry-safran requested a review from ejona86 February 14, 2025 19:27
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that warning is there for a reason. Seems we should just make our own copy of the variable. The most we should use the variable is have a test (since we control the okio version for tests) that verifies Segment.SIZE == SEGMENT_SIZE_COPY.

… just have a test check that they are equal.
@larry-safran larry-safran changed the title okhttp:Suppress the KotlinInternal warning for uses of Segment.SIZE in okhttp okhttp:Use a locally specified value instead of Segment.SIZE in okhttp Feb 14, 2025
@larry-safran larry-safran merged commit c1d7035 into grpc:master Feb 14, 2025
16 checks passed
@larry-safran larry-safran deleted the segment_size branch February 14, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants