Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DNS resolver #4

Merged
merged 3 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
255 changes: 255 additions & 0 deletions Sources/GRPCNIOTransportCore/Client/Resolver/DNSResolver.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,255 @@
/*
* Copyright 2024, gRPC Authors All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

private import Dispatch

#if canImport(Darwin)
package import Darwin
#elseif canImport(Glibc)
package import Glibc
#elseif canImport(Musl)
package import Musl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be private, not sure it makes sense for types from lib C to make it beyond the scope of this file.

#else
#error("The GRPCNIOTransportCore module was unable to identify your C library.")
#endif

@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
/// An asynchronous non-blocking DNS resolver built on top of the libc `getaddrinfo` function.
package enum DNSResolver {
private static let dispatchQueue = DispatchQueue(
label: "io.grpc.DNSResolver"
)

/// Resolves a hostname and port number to a list of socket addresses. This method is non-blocking.
package static func resolve(host: String, port: Int) async throws -> [SocketAddress] {
try Task.checkCancellation()

return try await withCheckedThrowingContinuation { continuation in
Self.dispatchQueue.async {
do {
let result = try Self.resolveBlocking(host: host, port: port)
continuation.resume(returning: result)
} catch {
continuation.resume(throwing: error)
}
}
}
}

/// Resolves a hostname and port number to a list of socket addresses.
///
/// Calls to `getaddrinfo` are blocking and this method calls `getaddrinfo` directly. Hence, this method is also blocking.
private static func resolveBlocking(host: String, port: Int) throws -> [SocketAddress] {
var result: UnsafeMutablePointer<addrinfo>?
defer {
if let result {
// Release memory allocated by a successful call to getaddrinfo
freeaddrinfo(result)
}
}

var hints = addrinfo()
hints.ai_socktype = SOCK_STREAM
hints.ai_protocol = IPPROTO_TCP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to convert to CInt here (which is expected by ai_protocol) as IPPROTO_TCP isn't always defined as a CInt:

Suggested change
hints.ai_protocol = IPPROTO_TCP
hints.ai_protocol = CInt(IPPROTO_TCP)


let errorCode = getaddrinfo(host, String(port), &hints, &result)

guard errorCode == 0, let result else {
throw Self.GetAddrInfoError(code: errorCode)
}

return try Self.parseResult(result)
}

/// Parses the linked list of DNS results (`addrinfo`), returning an array of socket addresses.
private static func parseResult(
_ result: UnsafeMutablePointer<addrinfo>
) throws -> [SocketAddress] {
var result = result
var socketAddresses = [SocketAddress]()

while true {
let addressBytes: UnsafeRawPointer = UnsafeRawPointer(result.pointee.ai_addr)

switch result.pointee.ai_family {
case AF_INET: // IPv4 address
let ipv4AddressStructure = addressBytes.load(as: sockaddr_in.self)
try socketAddresses.append(.ipv4(.init(ipv4AddressStructure)))
case AF_INET6: // IPv6 address
let ipv6AddressStructure = addressBytes.load(as: sockaddr_in6.self)
try socketAddresses.append(.ipv6(.init(ipv6AddressStructure)))
default:
()
}

guard let nextResult = result.pointee.ai_next else { break }
result = nextResult
}

return socketAddresses
}

/// Converts an address from a network format to a presentation format using `inet_ntop`.
fileprivate static func convertAddressFromNetworkToPresentationFormat(
addressPtr: UnsafeRawPointer,
family: CInt,
length: CInt
) throws -> String {
var presentationAddressBytes = [CChar](repeating: 0, count: Int(length))

return try presentationAddressBytes.withUnsafeMutableBufferPointer {
(presentationAddressBytesPtr: inout UnsafeMutableBufferPointer<CChar>) throws -> String in

// Convert
let presentationAddressStringPtr = inet_ntop(
family,
addressPtr,
presentationAddressBytesPtr.baseAddress!,
socklen_t(length)
)

if let presentationAddressStringPtr {
return String(cString: presentationAddressStringPtr)
} else {
throw Self.InetNetworkToPresentationError.systemError(errno: errno)
}
}
}
}

@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
extension DNSResolver {
/// `Error` that may be thrown based on the error code returned by `getaddrinfo`.
package enum GetAddrInfoError: Error, Hashable {
/// Address family for nodename not supported.
case addressFamilyForNodenameNotSupported

/// Temporary failure in name resolution.
case temporaryFailure

/// Invalid value for `ai_flags`.
case invalidAIFlags

/// Invalid value for `hints`.
case invalidHints

/// Non-recoverable failure in name resolution.
case nonRecoverableFailure

/// `ai_family` not supported.
case aiFamilyNotSupported

/// Memory allocation failure.
case memoryAllocationFailure

/// No address associated with nodename.
case noAddressAssociatedWithNodename

/// `hostname` or `servname` not provided, or not known.
case hostnameOrServnameNotProvidedOrNotKnown

/// Argument buffer overflow.
case argumentBufferOverflow

/// Resolved protocol is unknown.
case resolvedProtocolIsUnknown

/// `servname` not supported for `ai_socktype`.
case servnameNotSupportedForSocktype

/// `ai_socktype` not supported.
case socktypeNotSupported

/// System error returned in `errno`.
case systemError

/// Unknown error.
case unknown

package init(code: CInt) {
switch code {
case EAI_ADDRFAMILY:
self = .addressFamilyForNodenameNotSupported
case EAI_AGAIN:
self = .temporaryFailure
case EAI_BADFLAGS:
self = .invalidAIFlags
case EAI_BADHINTS:
self = .invalidHints
case EAI_FAIL:
self = .nonRecoverableFailure
case EAI_FAMILY:
self = .aiFamilyNotSupported
case EAI_MEMORY:
self = .memoryAllocationFailure
case EAI_NODATA:
self = .noAddressAssociatedWithNodename
case EAI_NONAME:
self = .hostnameOrServnameNotProvidedOrNotKnown
case EAI_OVERFLOW:
self = .argumentBufferOverflow
case EAI_PROTOCOL:
self = .resolvedProtocolIsUnknown
case EAI_SERVICE:
self = .servnameNotSupportedForSocktype
case EAI_SOCKTYPE:
self = .socktypeNotSupported
case EAI_SYSTEM:
self = .systemError
default:
self = .unknown
}
}
}
}

@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
extension DNSResolver {
/// `Error` that may be thrown based on the system error encountered by `inet_ntop`.
package enum InetNetworkToPresentationError: Error, Hashable {
case systemError(errno: errno_t)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make this a struct which stores the errno as a CInt

}

@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
extension SocketAddress.IPv4 {
fileprivate init(_ address: sockaddr_in) throws {
let presentationAddress = try withUnsafePointer(to: address.sin_addr) { addressPtr in
return try DNSResolver.convertAddressFromNetworkToPresentationFormat(
addressPtr: addressPtr,
family: AF_INET,
length: INET_ADDRSTRLEN
)
}

self = .init(host: presentationAddress, port: Int(in_port_t(bigEndian: address.sin_port)))
}
}

@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
extension SocketAddress.IPv6 {
fileprivate init(_ address: sockaddr_in6) throws {
let presentationAddress = try withUnsafePointer(to: address.sin6_addr) { addressPtr in
return try DNSResolver.convertAddressFromNetworkToPresentationFormat(
addressPtr: addressPtr,
family: AF_INET6,
length: INET6_ADDRSTRLEN
)
}

self = .init(host: presentationAddress, port: Int(in_port_t(bigEndian: address.sin6_port)))
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*
* Copyright 2024, gRPC Authors All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import GRPCNIOTransportCore
import Testing

@Suite("DNSResolver")
struct DNSResolverTests {
@Test("Resolve hostname")
func resolve() async throws {
// Note: This test checks the IPv4 and IPv6 addresses separately (instead of
// `DNSResolver.resolve(host: "localhost", port: 80)`) because the ordering of the resulting
// list containing both IP address versions can be different.

let expectedIPv4Result: [SocketAddress] = [.ipv4(host: "127.0.0.1", port: 80)]
let expectedIPv6Result: [SocketAddress] = [.ipv6(host: "::1", port: 80)]

let ipv4Result = try await DNSResolver.resolve(host: "127.0.0.1", port: 80)
let ipv6Result = try await DNSResolver.resolve(host: "::1", port: 80)

#expect(ipv4Result == expectedIPv4Result)
#expect(ipv6Result == expectedIPv6Result)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a paremeterized test, can be something like this:

Suggested change
@Test("Resolve hostname")
func resolve() async throws {
// Note: This test checks the IPv4 and IPv6 addresses separately (instead of
// `DNSResolver.resolve(host: "localhost", port: 80)`) because the ordering of the resulting
// list containing both IP address versions can be different.
let expectedIPv4Result: [SocketAddress] = [.ipv4(host: "127.0.0.1", port: 80)]
let expectedIPv6Result: [SocketAddress] = [.ipv6(host: "::1", port: 80)]
let ipv4Result = try await DNSResolver.resolve(host: "127.0.0.1", port: 80)
let ipv6Result = try await DNSResolver.resolve(host: "::1", port: 80)
#expect(ipv4Result == expectedIPv4Result)
#expect(ipv6Result == expectedIPv6Result)
}
@Test(
"Resolve hostname",
arguments: [
("127.0.0.1", .ipv4(host: "127.0.0.1", port: 80)),
("::1", .ipv6(host: "::1", port: 80)),
] as [(String, SocketAddress)].self
)
func resolve(host: String, expected: SocketAddress) async throws {
// Note: This test checks the IPv4 and IPv6 addresses separately (instead of
// `DNSResolver.resolve(host: "localhost", port: 80)`) because the ordering of the resulting
// list containing both IP address versions can be different.
let result = try await DNSResolver.resolve(host: host, port: 80)
#expect(result == expected)
}

}
Loading