Use path-to-underscore when generating files with the plugin #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The SwiftPM build plugin doesn't currently handle proto files with the same name even if they come from different packages. This happens because the build system cannot handle object files with the same name. This change adds such a test while tidying up some of the plugin test code. Modifications: - Divide up test resources in sources, config, and proto directories. - Have one function per test - Document each test with the expected structure - Add another test but don't run it. (It fails.) Result: More tests. The issue will be fixed in a separate change.
Motivation: The build system can't compile the code generated by the plugin when different proto files with the same name are used. This is allowed and expected if the files are in different proto packages. Modifications: - Use the "path to underscore" naming scheme instead of the "full path" naming scheme. This changes path components to underscores, so "foo/bar/baz.proto" would have "foo_bar_baz.grpc.swift" generated for it. - Uncomment test. Result: Test passes.
glbrntt
added
🔨 semver/patch
gjcairo
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The build system can't compile the code generated by the plugin when
different proto files with the same name are used. This is allowed and
expected if the files are in different proto packages.
Modifications:
naming scheme. This changes path components to underscores, so
"foo/bar/baz.proto" would have "foo_bar_baz.grpc.swift" generated for
it.
Result:
Test passes.