Support premove #223
Open
Support premove #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzhh
commented
Feb 18, 2024
| this.engineFacade.dragEndStrategy.process( | ||
| event, | ||
| this.engineFacade.moveDone, | ||
| piece === lastMove?.piece && length !== this.dragStartHistoryLength, |
There was a problem hiding this comment.
This was causing multiple bugs
When to detect on dragEnd if a move was done or not
-
If I dragdown a piece, and a move was done by opponent or bot, it piece I dragged down freezes
-
Comparing the last move piece with the dragged down piece:
What if you predict the next move, and you drag it down, and it really gets moved, it does get frozen
-> To resolve this, I had to implement disable drag of opponent pieces (Not elegeant but fine)
lorenzhh
commented
Feb 18, 2024
| } | ||
| possibleMoves = MoveUtils.findPieceByPossibleMovesContaining( | ||
| MoveUtils.formatSingle(destPoint, board.reverted), | ||
| board, | ||
| sourcePiece.color | ||
| ).filter(piece => piece.constructor.name === sourcePiece.constructor.name); | ||
| ).filter((piece) => piece.constant.name === sourcePiece.constant.name); |
There was a problem hiding this comment.
constructor name on production gets changed. Use constant name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.