This repository has been archived by the owner on Mar 25, 2018. It is now read-only.
feat: add option.exportName #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skad0
reviewed
Feb 22, 2017
index.js
Outdated
| if (file.isStream()) { | ||
| return callback(new PluginError(pluginName, 'Streaming not supported')); | ||
| if (options.extension) { | ||
| deprecate('options.extension: is deprecated. Please use `options.generator.extension` instead.'); |
qfox
reviewed
Feb 22, 2017
| * *String* **extension** — extension for file. Default — `.${engine}.js`. | ||
| * *Object* **engine** — XJST [options](https://github.com/bem/bem-xjst/blob/master/docs/en/3-api.md#settings). |
There was a problem hiding this comment.
Могу ошибаться, но @miripiruni это выпиливал (или exportName)
There was a problem hiding this comment.
Не понял вопроса, судя по доке опции работают
There was a problem hiding this comment.
Опции engine больше нет. Есть только exportName.
There was a problem hiding this comment.
В общем, коммент надо унести к exportName, а это зарезать.
Только не забыть про старые версии
birhoff
force-pushed
the
birhoff.feat.#55.add_export_name
branch
from
2299508 to
91e4175
Compare
birhoff
force-pushed
the
birhoff.feat.#55.add_export_name
branch
from
91e4175 to
81fc86b
Compare
|
🆙 Merge with @zxqfox Guys if you change codestyle in project. Please do this things:
|
|
@miripiruni is in progress with connected issue bem/bem-xjst#375 I think we should wait for him here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.