Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source typos #896

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix source typos #896

merged 1 commit into from
Feb 7, 2025

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Feb 6, 2025

Found via codespell -q 3 -w -L parm,parms,re-use,substract

Greenlit in #892

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (b14c187) to head (ce7d7d9).
Report is 12 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #896      +/-   ##
==========================================
+ Coverage   96.66%   96.72%   +0.05%     
==========================================
  Files          32       32              
  Lines        9219     9336     +117     
==========================================
+ Hits         8912     9030     +118     
+ Misses        307      306       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegenstein
Copy link
Collaborator

Thank you again. Can you also add spelling correction to these lines to your PR ?

greatest_common_demoninator = gcd(numerator, denominator)
return (
int(numerator / greatest_common_demoninator),
int(denominator / greatest_common_demoninator),

Found via `codespell -q 3 -w -L parm,parms,re-use,substract`
@luzpaz
Copy link
Contributor Author

luzpaz commented Feb 7, 2025

Done (apologies for missing those),

@jdegenstein
Copy link
Collaborator

Thanks again!

@jdegenstein jdegenstein merged commit 9c47669 into gumyr:dev Feb 7, 2025
20 checks passed
@luzpaz luzpaz deleted the typos-source branch February 7, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants