Update JDT #10082
Open
Update JDT #10082
+27
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
reviewed
Jan 9, 2025
Use JDT jars from maven central rather than packaging our own Fix gwtproject#10026
vegegoku
force-pushed
the
no-repackaging-jdt-test
branch
from
ea32cc4 to
eef092a
Compare
niloc132
reviewed
Jan 16, 2025
zbynek
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Also fixes a problem where bad classpath configuration caused the transitively included JDT 3.19 to be used, resulting in
java.lang.ArrayIndexOutOfBoundsException: Index 922 out of bounds for length 870
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:13150)
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:13407)
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:13364)
at com.google.gwt.dev.javac.JdtCompiler$ParserImpl.parse(JdtCompiler.java:210)
at org.eclipse.jdt.internal.compiler.parser.Parser.dietParse(Parser.java:11750)
at org.eclipse.jdt.internal.compiler.Compiler.internalBeginToCompile(Compiler.java:851)
at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:394)
at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:444)
at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:426)
The dependency chain is
org.eclipse.jetty:apache-jsp:9.4.44.v20210927
-> org.mortbay.jasper:apache-jsp:8.5.70
-> org.eclipse.jdt:ecj:3.19.0
niloc132
requested changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use JDT jars from maven central rather than packaging our own
Fix #10026