Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parliament.hackclub.com #1588

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

RezHackXYZ
Copy link

@RezHackXYZ RezHackXYZ commented Mar 10, 2025

Adding parliament.hackclub.com

Description

@astra.celestine has made a fun recreation of democracy/comunism in #parliament and I made the webiste... it is not compleete still a work in progress. (https://political-stuff-for-hc.vercel.app/)

@RezHackXYZ RezHackXYZ requested review from a team as code owners March 10, 2025 09:34
@RezHackXYZ RezHackXYZ marked this pull request as draft March 10, 2025 09:36
@Bluelightning26
Copy link
Member

I don’t think this belongs on the Hack Club domain, a dino.icu one might make more sense.

@RezHackXYZ
Copy link
Author

RezHackXYZ commented Mar 10, 2025

@Bluelightning26 the readme states that it is allowed for all projects related to hackclub, and this is well Parliment of Hack Club

image

@RezHackXYZ RezHackXYZ changed the title Adding parliment.hackclub.com Adding parliament.hackclub.com Mar 10, 2025
@RezHackXYZ RezHackXYZ marked this pull request as ready for review March 10, 2025 11:03
@RezHackXYZ
Copy link
Author

also you can currently view the page at: https://political-stuff-for-hc.vercel.app/

@NeonGamerBot-QK
Copy link
Member

@Bluelightning26 the readme states that it is allowed for all projects related to hackclub, and this is well Parliment of Hack Club

image

I think this is talking about hq approved projects

Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. Please get a member of hq to comment on this PR approving it
  2. You need to add the actual record for the site. You only have a verification record as of the moment. Find an example where there is a CNAME to vercel and copy it for this domain

You're also free to update your pr for a domain on dino.icu, which i can approve immediately

@3kh0
Copy link
Member

3kh0 commented Mar 10, 2025

Please do not, this project does not relate to HQ in any function and should not be registered with a hackclub.com domain.

@RezHackXYZ
Copy link
Author

Two things:

  1. Please get a member of hq to comment on this PR approving it
  2. You need to add the actual record for the site. You only have a verification record as of the moment. Find an example where there is a CNAME to vercel and copy it for this domain

You're also free to update your pr for a domain on dino.icu, which i can approve immediately

i am using vercle and it dosint realy work using a cname (shown bellow) so a txt will do...
image

and about hq member approving this... i will try but thanks

@alx-alexpark
Copy link
Member

You need a cname, see other examples in hackclub.com.yaml

@RezHackXYZ
Copy link
Author

i cant get it vercle is not giving an option for cname it is only txt verification

@Muirrum
Copy link
Member

Muirrum commented Mar 15, 2025

This is unrelated to verification. Follow the vercel instructions in the README

@RezHackXYZ
Copy link
Author

When adding a site hosted on ▲ Vercel, you will need to verifiy the domain by adding a TXT record.

image

Add the value to the hackclub.com.yaml file as shown below:

_vercel:
ttl: 600
type: TXT
values:
- vc-domain-verify=wackclub.hackclub.com,423c28e0fbdd51449cf1

^ is what is in the readme and exactly what i have done...

@Muirrum
Copy link
Member

Muirrum commented Mar 15, 2025

Whoops that's my bad. Use cname.vercel-dns.com.

Additionally, please move to dino.icu before proceeding further.

@Muirrum
Copy link
Member

Muirrum commented Mar 23, 2025

@RezHackXYZ please move this domain to dino.icu and add the Vercel records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants