Update CI, add cargo fmt #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using VS Code YAML extension by Red Hat
- updates actions/checkout from v1 (2019) to v4 (2023) - switches toolchain from actions-rs (archive status) to dtolnay - uses rust-cache - adds `cargo fmt` to the workflow Many of these changes were inspired by Axum's CI.
|
I didn't add a doc job for #214 but I could do that after. |
hannobraun
approved these changes
Sep 17, 2024
| @@ -1,40 +1,46 @@ | |||
| name: Rust | |||
|
|
|||
| env: | |||
| MSRV: "1.70" | |||
There was a problem hiding this comment.
I wonder, if there's a way to specify the MSRV only in a single place. (It's also specified in Cargo.toml as rust-version.)
I realize that this pull request doesn't add any new redundancies (this line replaces another in the same file), so this isn't a criticism. This just reminded me of this redundancy, and I'm wondering if we can do better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmtto the workflowMany of these changes were inspired by Axum's CI.
fmt run, all clippy lints fixed, CI passing on my fork.