test: investigate crossterm windows 10 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Investigated crossterm failure when running Console Wallet in Windows 10 and Windows Console Host. The backend crossterm process dies with maximize -> reset ``` 2025-01-20 16:20:11.499961300 [wallet::app::crossterm_events] ERROR Internal error in crossterm events, tick rate: 249.9999ms, err: No process is on the other end of the pipe. (os error 233) 2025-01-20 16:20:12.415411300 [wallet::console_wallet::wallet_event_monitor] TRACE Wallet Event Monitor received wallet connectivity event PeerConnectFailed(NodeId(85d605836f02951c65651f99d0)) 2025-01-20 16:20:12.500616800 [wallet::ui::app] TRACE Key event: RestartCrosstermLoop 2025-01-20 16:20:12.500709300 [wallet::ui::app] ERROR Error clearing interface. No process is on the other end of the pipe. (os error 233) ```
Test Results (CI)0 tests 0 ✅ 0s ⏱️ Results for commit e0b0e58. |
Test Results (Integration tests)0 tests 0 ✅ 0s ⏱️ Results for commit e0b0e58. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Investigated crossterm failure when running Console Wallet in Windows 10 and Windows Console Host (see tari-project#6729).
tldr; The backend crossterm process dies with maximize -> reset. This also holds for the latest release
crossterm = { version = "0.28.1" }Test code was added to capture and act on the
crosterm::event::pollerrer (No process is on the other end of the pipe. (os error 233)). As soon as this polling error is encountered, an eventEvent::RestartCrosstermLoopis sent to the terminal, which is of typeTerminal<CrosstermBackend<StdOut>>. The terminal then tries to clear itself, upon which the same OS error is returned. As soon as thefn crossterm_loop(is exited, the terminal dies.Motivation and Context
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes