Skip to content

Commit

Permalink
Fix CI not running on push (#296)
Browse files Browse the repository at this point in the history
  • Loading branch information
harryzcy authored May 28, 2023
1 parent 5273f98 commit 1a75441
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 9 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ name: Lint

on:
push:
branches:
- "**"
tags-ignore:
- 'v*'
- "v*"
pull_request:
branches: [ main ]
branches:
- main

permissions:
contents: read
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
branches:
- main
tags-ignore:
- 'v*'
- "v*"
pull_request:
types: [opened, reopened, synchronize]

Expand All @@ -15,8 +15,8 @@ permissions:
jobs:
update_release_draft:
permissions:
contents: write # for release-drafter/release-drafter to create a github release
pull-requests: write # for release-drafter/release-drafter to add label to PR
contents: write # for release-drafter/release-drafter to create a github release
pull-requests: write # for release-drafter/release-drafter to add label to PR
runs-on: ubuntu-latest
steps:
# Drafts your next Release notes as Pull Requests are merged into "main"
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,21 @@ name: Tests

on:
push:
branches:
- "**"
tags-ignore:
- 'v*'
- "v*"
pull_request:
branches: [ main ]
branches:
- main

jobs:
go-test:
name: Go Tests
uses: harryzcy/github-actions/.github/workflows/go.yml@main
with:
working-directory: bff

jest-test:
name: Jest Tests
runs-on: ubuntu-latest
Expand All @@ -25,7 +28,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '18'
node-version: "18"

- name: Install dependencies
run: npm ci
Expand Down

0 comments on commit 1a75441

Please sign in to comment.