Allow for a Fully-Qualified Hostname #931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fqdn fix -> allfixes
Add check to make sure DHCP route error only shows for DHCP setups
Yu-Jack
requested changes
Feb 12, 2025
1.4.1 allfixes
This reverts commit bdac4df.
|
@tayterz2 BTW, please use rebase master, thank you! |
|
@Yu-Jack - I rebased 2 days ago, and currently github reports this branch as caught up. What am I missing? Thanks! |
|
Hi @tayterz2 I think you can rebase again. Or just open another branch based on master, cherry-pick your commit and force push it to this branch again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When using domain names in hostnames, inform RancherD and the Dashboard that this is the proper hostname.
Solution:
Add hostname to rancherd node adds, and perform "hostnamectl" instead of "hostname" to pull the FQDN from the hosts.
Related Issue:
harvester/harvester#7312
Test plan:
Install Harvester with an FQDN as hostname (taylor.rancher.io) and observe that same hostname in the "hosts" and "node" fields throughout.