Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use same COS_* partition sizes regardless of seaparate data disk (backport #968) #972

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 12, 2025

Problem:
When Harvester is installed with a single disk shared between OS and data, we set the COS_STATE parittion size to 15G. When using a separate data disk, we just use the Elemental default partition layout, which only gives COS_STATE of 8G. This causes problems with upgrades due to lack of space.

Solution:
This commit ensures we set a 15G COS_STATE parition in both of the above cases.

Related Issue:

Test plan:

  • Install Harvester with a shared OS/data disk. Check the COS_OEM, COS_RECOVERY and COS_STATE partition sizes:
    # lsblk -o NAME,LABEL,SIZE
    NAME    LABEL             SIZE
    [...]
    vda                       500G
    ├─vda1                      1M
    ├─vda2  COS_OEM            50M          <-- 50M is correct
    ├─vda3  COS_RECOVERY        8G          <-- 8G is correct
    ├─vda4  COS_STATE          15G          <-- 15G is correct
    ├─vda5  COS_PERSISTENT    150G
    └─vda6  HARV_LH_DEFAULT 326.9G
    [...]
    
  • Install Harvester with a separate data disk. Check the COS_OEM, COS_RECOVERY and COS_STATE partition sizes. They should be the same as above:
    # lsblk -o NAME,LABEL,SIZE
    NAME   LABEL             SIZE
    [...]
    vda                      250G
    ├─vda1 COS_GRUB           64M
    ├─vda2 COS_OEM            50M          <-- 50M is correct
    ├─vda3 COS_RECOVERY        8G          <-- 8G is correct
    ├─vda4 COS_STATE          15G          <-- 15G is correct
    └─vda5 COS_PERSISTENT  226.9G
    vdb    HARV_LH_DEFAULT   128G
    
    (Ignore COS_GRUB -- in the examples above one node was installed with BIOS, the other with UEFI, sorry for any confusion)
  • Prior to this fix, if you were to install Harvester with a separate data disk, COS_RECOVERY would only be 4G, and COS_STATE would be 8G.
    This is an automatic backport of pull request fix: use same COS_* partition sizes regardless of seaparate data disk #968 done by Mergify.

When Harvester is installed with a single disk shared between OS and
data, we set the COS_STATE parittion size to 15G. When using a separate
data disk, we just use the Elemental default partition layout, which
only gives COS_STATE of 8G. This causes problems with upgrades due to
lack of space.

This commit ensures we set a 15G COS_STATE parition in both of the above
cases.

Related issue: harvester/harvester#7457
Related issue: harvester/harvester#7493

Signed-off-by: Tim Serong <tserong@suse.com>
(cherry picked from commit e12e251)
@tserong tserong merged commit 406fc28 into v1.4 Feb 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants