Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flag size and include additional improvements in phone input #42

Merged
merged 4 commits into from
Nov 24, 2024

Conversation

omeralpi
Copy link
Contributor

@omeralpi omeralpi commented Nov 23, 2024

Fixes #41

This PR focuses on fixing the issue where flags in the PhoneInput component appeared smaller than the container background. The solution involves adjusting the span wrapper styles for correct flag sizing.

Additionally, the following improvements are included:

  • Fix: Reposition CommandInput (search) above CommandList to ensure correct behavior with fixed placement.
  • Fix: Disable smart caret behavior to resolve cursor issues on mobile devices.
    Reference: PR #49 from the shadcn-phone-input package.
  • Fix: Update button styling by reducing the left border width from 2px to 1px for improved visual consistency.

Copy link

vercel bot commented Nov 23, 2024

@omeralpi is attempting to deploy a commit to the hasanharman's projects Team on Vercel.

A member of the Team first needs to authorize it.

kazim-kayhan
kazim-kayhan approved these changes Nov 24, 2024
Copy link
Owner

@hasanharman hasanharman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Thanks a lot

@hasanharman hasanharman merged commit f498c62 into hasanharman:main Nov 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Flags are sometimes not displayed properly in PhoneInput
3 participants