fix: unit tests failing in CI #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 644 644
Branches 118 118
=======================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
konstantinabl
force-pushed
the
2223-unit-tests-failing-in-ci
branch
from
aadb3fa to
bf34483
Compare
konstantinabl
requested review from
Ivo-Yankov,
georgi-l95,
natanasow and
victor-yanev
konstantinabl
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
Ivo-Yankov
previously approved these changes
Mar 29, 2024
georgi-l95
force-pushed
the
2223-unit-tests-failing-in-ci
branch
from
0a995bc to
d185259
Compare
Wiz Scan Summary
|
AlfredoG87
previously approved these changes
Apr 3, 2024
georgi-l95
force-pushed
the
2223-unit-tests-failing-in-ci
branch
from
387e005 to
dbe47ce
Compare
konstantinabl
force-pushed
the
2223-unit-tests-failing-in-ci
branch
from
dbe47ce to
7374fc8
Compare
victor-yanev
previously approved these changes
Apr 26, 2024
konstantinabl
dismissed stale reviews from georgi-l95 and victor-yanev
via
ef6eb8c
Nana-EC
previously approved these changes
May 7, 2024
konstantinabl
force-pushed
the
2223-unit-tests-failing-in-ci
branch
from
ef6eb8c to
2d54d8f
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl
force-pushed
the
2223-unit-tests-failing-in-ci
branch
from
2d54d8f to
df641f8
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl
force-pushed
the
2223-unit-tests-failing-in-ci
branch
from
df641f8 to
a01d828
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the precheck.spec.ts file to resolve a TypeError occurring in the ethers package when using node version 20. The error arises because the 'from' field in the transaction doesn't match the signer's address.
It also adds return types and JSDoc where missing.
Related issue(s):
Fixes #2223
Notes for reviewer:
Checklist