fix: Adds return types where missing in eth.ts #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantinabl
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
konstantinabl
requested review from
Ivo-Yankov,
georgi-l95,
natanasow and
victor-yanev
konstantinabl
force-pushed
the
2264-add-return-types-in-ethts-where-missing
branch
from
2f69ca0 to
b62aa2b
Compare
konstantinabl
force-pushed
the
2264-add-return-types-in-ethts-where-missing
branch
2 times, most recently
from
c3c79a9 to
8cbb200
Compare
Nana-EC
reviewed
Apr 27, 2024
AlfredoG87
approved these changes
May 6, 2024
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
…cies Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl
force-pushed
the
2264-add-return-types-in-ethts-where-missing
branch
from
8cbb200 to
89995b9
Compare
|
quiet-node
pushed a commit
that referenced
this pull request
May 20, 2024
* Merges main Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Removes unused import Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds return types to eth.ts; Refactors fee history to remove redundancies Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds transaction receipt interface Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
quiet-node
pushed a commit
that referenced
this pull request
May 20, 2024
* Merges main Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Removes unused import Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds return types to eth.ts; Refactors fee history to remove redundancies Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds transaction receipt interface Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
added a commit
that referenced
this pull request
May 20, 2024
fix: Adds return types where missing in eth.ts (#2265) * Merges main * Removes unused import * Adds return types to eth.ts; Refactors fee history to remove redundancies * Adds transaction receipt interface --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Co-authored-by: konstantinabl <konstantina.blajukova@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds return types to any functions missing them in the eth.ts file
Related issue(s):
Fixes #2264