fix: removed chainId field for legacy EIP155 transactions (#2468) #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
Nana-EC
requested changes
May 13, 2024
packages/relay/src/formatters.ts
Outdated
| @@ -147,7 +147,7 @@ const formatContractResult = (cr: any) => { | |||
| const commonFields = { | |||
| blockHash: toHash32(cr.block_hash), | |||
| blockNumber: nullableNumberTo0x(cr.block_number), | |||
| chainId: cr.chain_id, | |||
| chainId: cr.chain_id === '0x' ? undefined : cr.chain_id, | |||
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
2468-wrong-formatting-of-pre-eip155-transactions
branch
from
c7ebc0e to
3be64cf
Compare
Nana-EC
reviewed
May 15, 2024
packages/relay/src/formatters.ts
Outdated
| @@ -147,7 +147,7 @@ const formatContractResult = (cr: any) => { | |||
| const commonFields = { | |||
| blockHash: toHash32(cr.block_hash), | |||
| blockNumber: nullableNumberTo0x(cr.block_number), | |||
| chainId: cr.chain_id, | |||
| chainId: cr.chain_id === EMPTY_HEX ? undefined : cr.chain_id, | |||
There was a problem hiding this comment.
nit: add a comment on what this does and why so other devs understand
Nana-EC
previously approved these changes
May 15, 2024
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
|
quiet-node
added a commit
that referenced
this pull request
May 21, 2024
) * fix: removed chainId field for legacy EIP155 transactions Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * test: added UT Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * chore: added explanation Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR simply remove the chainId field if the transaction result is a legacy EIP155 transaction whose chainId equals to "0x".
Related issue(s):
Fixes #2468
Notes for reviewer:
Checklist