-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cherry pick PR2504 #2541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
ebadiere,
Nana-EC and
a team
as code owners
May 28, 2024 15:39
* Add Koa Server Request Timeout Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> * fix: Added test and documentation to the server request timeout setting. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added doc updated. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped timeout to 60 seconds. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: removed only. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added empty line. Signed-off-by: ebadiere <ebadiere@gmail.com> Update packages/server/src/index.ts Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> fix: Applied feedback Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added back the chai. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Restored the chai exclude Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed the async in the sendJsonRpcRequestWithDelay Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Reduced the timeout to allow tests to finish. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Moved timeout test to rateLimiter. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed comma after LIMIT_DURATION Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout delay to ensure it works in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Testing in CI. Removed the .only Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Adjusted the test delay. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added error details. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added more debug info. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added delay for linux. Debugging in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Setting test timeout Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Nested promise. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Including delay in testfile. Debugging CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CIfix: Debugging in CI. Updated package-log. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Extracted setting logic to util function to be used in server startup and test framework Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout for tests on local node. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Moved into its own CI job. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Cleanup Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Clean up. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
cherry-pick-2504
branch
from
May 28, 2024 15:40
bbc41a4
to
33d0360
Compare
Quality Gate passedIssues Measures |
AlfredoG87
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry pick #2504
Related issue(s):
Fixes #
Notes for reviewer:
Checklist