Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick PR2504 #2541

Merged
merged 1 commit into from
May 28, 2024
Merged

chore: Cherry pick PR2504 #2541

merged 1 commit into from
May 28, 2024

Conversation

quiet-node
Copy link
Member

Description:
Cherry pick #2504

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label May 28, 2024
@quiet-node quiet-node added this to the 0.48.0 milestone May 28, 2024
@quiet-node quiet-node self-assigned this May 28, 2024
@quiet-node quiet-node requested review from AlfredoG87, ebadiere, Nana-EC and a team as code owners May 28, 2024 15:39
* Add Koa Server Request Timeout

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>

* fix: Added test and documentation to the server request timeout setting.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Added doc updated.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Bumped timeout to 60 seconds.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: removed only.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Added empty line.

Signed-off-by: ebadiere <ebadiere@gmail.com>

Update packages/server/src/index.ts

Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Eric Badiere <ebadiere@gmail.com>

fix: Applied feedback

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Added back the chai.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Restored the chai exclude

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Removed the async in the sendJsonRpcRequestWithDelay

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Reduced the timeout to allow tests to finish.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Moved timeout test to rateLimiter.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Removed comma after LIMIT_DURATION

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Bumped up the timeout delay to ensure it works in CI.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Testing in CI.  Removed the .only

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Adjusted the test delay.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Added error details.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Added more debug info.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Added delay for linux.  Debugging in CI.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Debugging in CI.  Setting test timeout

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Debugging in CI.  Nested promise.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Including delay in testfile.  Debugging CI.

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Debugging in CIfix: Debugging in CI.  Updated package-log.
Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Extracted setting logic to util function to be used in server startup and test framework

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix:  Bumped up the timeout for tests on local node.

Signed-off-by: ebadiere <ebadiere@gmail.com>

* fix: Moved into its own CI job.

Signed-off-by: ebadiere <ebadiere@gmail.com>

* fix: Cleanup

Signed-off-by: ebadiere <ebadiere@gmail.com>

* fix: Clean up.

Signed-off-by: ebadiere <ebadiere@gmail.com>

---------

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Co-authored-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Tests

    2 files  148 suites   13s ⏱️
829 tests 828 ✔️ 1 💤 0
841 runs  840 ✔️ 1 💤 0

Results for commit 33d0360.

Copy link

github-actions bot commented May 28, 2024

Acceptance Tests

     22 files     337 suites   37m 23s ⏱️
   592 tests    585 ✔️   3 💤   4
1 204 runs  1 179 ✔️ 15 💤 10

Results for commit 33d0360.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node merged commit 859fc4a into release/0.48 May 28, 2024
34 checks passed
@quiet-node quiet-node deleted the cherry-pick-2504 branch May 28, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants