fix: fixed requests throw error when both data and input fields are present in transaction object #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
…resent in transaction object Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
|
ebadiere
deleted the
2547-accept-the-requests-with-both-data-input-fields-ignore-the-extra-parameter-instead-of-throwing-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixed requests throw error when both data and input fields are present in transaction object.
datafield -> no modificationinputfield -> copy value ofinputtodata& deleteinputdataandinputfielddata& deleteinputinputtodata& deleteinputRelated issue(s):
Fixes #2547
Fixes #2550
Notes for reviewer:
Checklist