Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry picked debug_traceTransaction #2630

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

quiet-node
Copy link
Member

Description:
Cherry pick PR#2480 and PR#2628 to release/0.50

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the process Build, test and deployment-process related tasks label Jun 27, 2024
@quiet-node quiet-node added this to the 0.50.0 milestone Jun 27, 2024
@quiet-node quiet-node self-assigned this Jun 27, 2024
Copy link
Contributor

@victor-yanev victor-yanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just a few concerns

Copy link

github-actions bot commented Jun 27, 2024

Tests

    2 files  157 suites   14s ⏱️
853 tests 852 ✔️ 1 💤 0
865 runs  864 ✔️ 1 💤 0

Results for commit 453b8f0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 27, 2024

Acceptance Tests

  17 files  220 suites   28m 58s ⏱️
604 tests 600 ✔️ 3 💤 1
667 runs  663 ✔️ 3 💤 1

Results for commit 453b8f0.

♻️ This comment has been updated with latest results.

victor-yanev and others added 2 commits June 27, 2024 11:46
* feat: Enhance debug_traceTransaction to work with Opcode Logger

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

* feat: Enhance debug_traceTransaction to work with Opcode Logger

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

* chore: Remove unused imports and config variable in debug.spec.ts

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

* chore: extract `getQueryParams` to helpers.ts

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

* chore: fix validation

Signed-off-by: nikolay <n.atanasow94@gmail.com>

* chore: final touches

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

* fix: error message in param validations

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

* test: fix expected error message in server.spec.ts

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

* fix: tests in debug.spec.ts

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

* fix: remove unused import

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

---------

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Co-authored-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
…ig (#2628)

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the cherry-pick-debug_traceTransaction branch from 2b0b214 to 453b8f0 Compare June 27, 2024 15:46
Copy link

@quiet-node quiet-node merged commit 2c7330c into release/0.50 Jun 27, 2024
33 checks passed
@quiet-node quiet-node deleted the cherry-pick-debug_traceTransaction branch June 27, 2024 17:08
@Nana-EC Nana-EC modified the milestones: 0.50.0, 0.50.2 Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants