fix: net_version now reads chainId from config and return decimal val… #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue (#2633) * fix: net_version now reads chainId from config and return decimal value Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: fixed regex pattern for postman test Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
ebadiere
requested review from
AlfredoG87,
Nana-EC,
a team and
lukelee-sl
as code owners
|
quiet-node
approved these changes
Jul 1, 2024
ebadiere
added a commit
that referenced
this pull request
Jul 3, 2024
#2645) fix: net_version now reads chainId from config and return decimal value (#2633) * fix: net_version now reads chainId from config and return decimal value * fix: fixed regex pattern for postman test --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
added a commit
that referenced
this pull request
Jul 3, 2024
* fix: net_version now reads chainId from config and return decimal val… (#2645) fix: net_version now reads chainId from config and return decimal value (#2633) * fix: net_version now reads chainId from config and return decimal value * fix: fixed regex pattern for postman test --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: issue when trying to perform transaction (#2663) Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Co-authored-by: Georgi Lazarov <glazarov95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick PR#2633