Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Golang tests to workflow #2679

Merged
merged 3 commits into from
Aug 12, 2024
Merged

feat: add Golang tests to workflow #2679

merged 3 commits into from
Aug 12, 2024

Conversation

marcin-piela-ariane
Copy link
Contributor

@marcin-piela-ariane marcin-piela-ariane commented Jul 4, 2024 •
edited
Loading

Description:

This PR adds:

  • ability to run Golang JSON RPC tests against local node,
  • execution of Golang JSON RPC tests to dev-tool-test workflow.

Related issue(s):

Closes #2681

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@marcin-piela-ariane marcin-piela-ariane force-pushed the golang-json-rpc-workflow branch 2 times, most recently from 105d3a9 to 0749691 Compare July 5, 2024 13:57
@marcin-piela-ariane marcin-piela-ariane mentioned this pull request Jul 5, 2024
Closed
@marcin-piela-ariane marcin-piela-ariane force-pushed the golang-json-rpc-workflow branch from 0749691 to 124cbac Compare July 5, 2024 14:35
@marcin-piela-ariane marcin-piela-ariane marked this pull request as ready for review July 5, 2024 14:36
@marcin-piela-ariane
feat: added option to run Golang JSON RPC methods against local node …
b2542b9 
…& added Golang JSON RPC workflow (hashgraph#2681)

Signed-off-by: Marcin Piela (ArianeLabs) <marcin.piela@arianelabs.com>
@marcin-piela-ariane marcin-piela-ariane force-pushed the golang-json-rpc-workflow branch from 124cbac to b2542b9 Compare July 5, 2024 14:42
Nana-EC
Nana-EC reviewed Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, some suggestions provided

tools/golang-json-rpc-tests/.env.example Show resolved Hide resolved
.github/workflows/dev-tool-test.yml Outdated Show resolved Hide resolved
@marcin-piela-ariane
feat: separated HTTP & WSS tests for Golang JSON RPC workflow (hashgr…
aa0aeda 
…aph#2681)

Signed-off-by: Marcin Piela (ArianeLabs) <marcin.piela@arianelabs.com>
@quiet-node quiet-node added the enhancement New feature or request label Jul 15, 2024
@quiet-node quiet-node added this to the 0.53.0 milestone Jul 15, 2024
Nana-EC
Nana-EC previously approved these changes Jul 19, 2024
View reviewed changes
quiet-node
quiet-node previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG just one quick question.

tools/golang-json-rpc-tests/.env.example Show resolved Hide resolved
@marcin-piela-ariane
feat: changed comment in .env.example (hashgraph#2681)
85a6a19 
Signed-off-by: Marcin Piela (ArianeLabs) <marcin.piela@arianelabs.com>
@marcin-piela-ariane marcin-piela-ariane dismissed stale reviews from quiet-node and Nana-EC via 85a6a19 July 22, 2024 08:33
acuarica
acuarica reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, left comment

.github/workflows/dev-tool-workflow.yml Show resolved Hide resolved
@se7enarianelabs se7enarianelabs added the ArianeLabs Items ArianeLabs is contributing to label Aug 1, 2024
acuarica
acuarica approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

quiet-node
quiet-node approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quiet-node quiet-node merged commit 0485787 into hashgraph:main Aug 12, 2024
32 of 34 checks passed
@quiet-node quiet-node modified the milestones: 0.53.0, 0.54.0 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuarica acuarica acuarica approved these changes

@quiet-node quiet-node quiet-node approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87

@ebadiere ebadiere Awaiting requested review from ebadiere

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@matteriben matteriben Awaiting requested review from matteriben matteriben was automatically assigned from hashgraph/release-engineering

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@Nana-EC Nana-EC Awaiting requested review from Nana-EC

Assignees

@marcin-piela-ariane marcin-piela-ariane

Labels
ArianeLabs Items ArianeLabs is contributing to enhancement New feature or request
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.54.0
Development

Successfully merging this pull request may close these issues.

Add Golang tests to workflow
5 participants
@marcin-piela-ariane @acuarica @Nana-EC @quiet-node @se7enarianelabs