feat: track hbar expenses for submit tx #2705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
commented
Jul 16, 2024
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
Nana-EC
reviewed
Jul 17, 2024
| } | ||
| const transactionRecord = await new TransactionRecordQuery() | ||
| .setTransactionId(resp.transactionId!) | ||
| .setValidateReceiptStatus(false) |
There was a problem hiding this comment.
Missing the nodeIds selection.
Was this intentionally left out?
I believe the optimization allows for you to get it from the node you submitted to for shorter latency.
| if (shouldLimit) { | ||
| throw predefined.HBAR_RATE_LIMIT_EXCEEDED; | ||
| } | ||
| const transactionRecord = await new TransactionRecordQuery() |
There was a problem hiding this comment.
Use executeQuery() as it will handle metric and hbar rate limit
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
|
victor-yanev
approved these changes
Jul 19, 2024
|
Replaced by #2714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR modifies submit transaction logic to account for hbar expenses. Previously we didn't track operator expenses for ethereum transactions. This PR is using executeGetTransactionRecord method, which takes the record and deduct the cost from the budget.
Related issue(s):
Fixes #2703
Notes for reviewer:
Checklist