-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: example web3py usage #2723
Conversation
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, left some comment
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some more comments, going in the right direction
…th args and return types Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀, some nits.
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
bad6853
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG but two minor change requests
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Hey @mateuszm-arianelabs, there are some outstanding comments. Would you be able to address them so we can merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@quiet-node Should be fixed, can you resolve it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2723 +/- ##
==========================================
- Coverage 84.48% 84.40% -0.09%
==========================================
Files 40 56 +16
Lines 3056 3770 +714
Branches 632 771 +139
==========================================
+ Hits 2582 3182 +600
- Misses 274 351 +77
- Partials 200 237 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
|
Description:
Creates an example project demonstrating Web3py usage with Hedera
Related issue(s):
Implements # #2724
Notes for reviewer:
Checklist