Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: example web3py usage #2723

Closed
wants to merge 7 commits into from

Conversation

mateuszm-arianelabs
Copy link
Contributor

@mateuszm-arianelabs mateuszm-arianelabs commented Jul 19, 2024

Description:
Creates an example project demonstrating Web3py usage with Hedera

Related issue(s):

Implements # #2724

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
@mateuszm-arianelabs mateuszm-arianelabs changed the title feat: example web3py usage test: example web3py usage Jul 19, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, left some comment

tools/web3py-example/scripts/test.py Outdated Show resolved Hide resolved
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some more comments, going in the right direction

tools/web3py-example/README.md Outdated Show resolved Hide resolved
tools/web3py-example/scripts/test.py Outdated Show resolved Hide resolved
tools/web3py-example/scripts/test.py Show resolved Hide resolved
…th args and return types

Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
acuarica
acuarica previously approved these changes Jul 29, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

quiet-node
quiet-node previously approved these changes Jul 31, 2024
@quiet-node quiet-node added the enhancement New feature or request label Jul 31, 2024
@quiet-node quiet-node added this to the 0.54.0 milestone Jul 31, 2024
Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀, some nits.

tools/web3py-example/scripts/test.py Outdated Show resolved Hide resolved
tools/web3py-example/scripts/test.py Outdated Show resolved Hide resolved
tools/web3py-example/contract/Greeter.sol Outdated Show resolved Hide resolved
@se7enarianelabs se7enarianelabs added the ArianeLabs Items ArianeLabs is contributing to label Aug 1, 2024
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG but two minor change requests

tools/web3py-example/contract/Greeter.sol Outdated Show resolved Hide resolved
tools/web3py-example/scripts/test.py Outdated Show resolved Hide resolved
Signed-off-by: mateuszm-arianelabs <mateusz.marcinkowski@arianelabs.com>
@acuarica
Copy link
Contributor

Hey @mateuszm-arianelabs, there are some outstanding comments. Would you be able to address them so we can merge this?

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@se7enarianelabs
Copy link
Contributor

se7enarianelabs commented Sep 6, 2024

LG but two minor change requests

@quiet-node Should be fixed, can you resolve it?

@quiet-node quiet-node modified the milestones: 0.55.0, 0.56.0 Sep 6, 2024
@lukelee-sl lukelee-sl added Audit and removed Audit labels Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (3648684) to head (0c18dac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2723      +/-   ##
==========================================
- Coverage   84.48%   84.40%   -0.09%     
==========================================
  Files          40       56      +16     
  Lines        3056     3770     +714     
  Branches      632      771     +139     
==========================================
+ Hits         2582     3182     +600     
- Misses        274      351      +77     
- Partials      200      237      +37     
Flag Coverage Δ
relay 84.48% <ø> (ø)
server 83.05% <ø> (?)
ws-server 97.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

@arianejasuwienas
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArianeLabs Items ArianeLabs is contributing to enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants