chore: cherry picked PR#2714 #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
Nana-EC
approved these changes
Jul 19, 2024
ebadiere
approved these changes
Jul 19, 2024
…cuteTransaction and deleteFile (#2714) * fix: captured transaction fee in metrics and hbar limiter class for executeTransaction Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: captured transaction fee in hbar limiter class for deleteFile Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: improved the logic of capturing transaction fees to metrics in executeTransaction Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: improved error handling logic for sendRawTransaction Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> fix: added polling logic to retrieve updated account nonce for WRONG_NONCE error handler Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: removed non-existed NEXT_STORAGE_CONTRACT_UPDATE singature hash Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: added logic to throw WRONG_NONCE error Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: tweaked and reused executeGetTransactionRecord Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: fixed http rate limiter failing test Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: reverted shouldLimit check Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Revert "fix: captured transactionFee in metrics and HBAR limiter class in executeTransaction and deleteFile (#2714)" This reverts commit 46c5a76. Reapply "fix: captured transactionFee in metrics and HBAR limiter class in executeTransaction and deleteFile (#2714)" This reverts commit 3a217efecca4c94f93bf995008f297696d9c8ce9.
quiet-node
force-pushed
the
cherry-pick-PR#2730-52.0
branch
from
46c5a76 to
838d8b0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry picked #2714 to release/0.52
Related issue(s):
Fixes #
Notes for reviewer:
Checklist