Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create second batch of additional conformity tests #2889

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Aug 27, 2024

Description:

Create tests similar to the ones in this repo for the following endpoints

  • - eth_newBlockFilter
  • - eth_newFilter
  • - eth_uninstallFilter
  • - eth_newPendingTransactionFilter
  • - eth_getFilterLogs
  • - eth_getFilterChanges
  • - eth_protocolVersion
  • - eth_sendTransaction
  • - eth_signTransaction
  • - eth_sign
  • - eth_submitHashrate

Related issue(s):

Fixes #2726

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow self-assigned this Aug 27, 2024
@natanasow natanasow added this to the 0.55.0 milestone Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

Tests

       3 files     216 suites   16s ⏱️
1 134 tests 1 133 ✔️ 1 💤 0
1 146 runs  1 145 ✔️ 1 💤 0

Results for commit a7b3dd9.

♻️ This comment has been updated with latest results.

@natanasow natanasow added the enhancement New feature or request label Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

Acceptance Tests

  20 files  229 suites   31m 15s ⏱️
597 tests 592 ✔️ 4 💤 1
612 runs  604 ✔️ 4 💤 4

Results for commit a7b3dd9.

♻️ This comment has been updated with latest results.

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Copy link

@natanasow natanasow marked this pull request as ready for review August 28, 2024 08:41
@natanasow natanasow requested review from AlfredoG87, ebadiere, Nana-EC and a team as code owners August 28, 2024 08:41
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@natanasow natanasow merged commit 1fc40e3 into main Aug 29, 2024
45 checks passed
@natanasow natanasow deleted the 2726-create-second-batch-of-comformity-tests branch August 29, 2024 08:20
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (76582fa) to head (a7b3dd9).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
+ Coverage   82.70%   82.94%   +0.24%     
==========================================
  Files          47       47              
  Lines        3457     3483      +26     
  Branches      731      739       +8     
==========================================
+ Hits         2859     2889      +30     
+ Misses        371      364       -7     
- Partials      227      230       +3     
Flag Coverage Δ
relay 82.66% <ø> (-0.13%) ⬇️
server 83.05% <ø> (+1.83%) ⬆️
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create second batch of additional conformity test
3 participants