ci: Fix issue with github_env echo statements #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Details**: Updates the OPERATOR_KEY_MAIN environment variable storage to use a masked value. **Related Issues**: Fixes: #3011 Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
rbarker-dev
requested review from
AlfredoG87,
ebadiere,
Nana-EC and
a team
as code owners
rbarker-dev
requested review from
JeffreyDallas,
jeromy-cannon and
nathanklick
and removed request for
JeffreyDallas
nathanklick
requested changes
Sep 18, 2024
nathanklick
requested changes
Sep 18, 2024
level env section. Removing the need for the manual assign step in acceptance-workflow Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
|
Nana-EC
approved these changes
Sep 18, 2024
nathanklick
approved these changes
Sep 18, 2024
beeradb
approved these changes
Sep 18, 2024
rbarker-dev
deleted the
3011-update-workflows-to-mask-operator-key-when-manually-used
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
+ Coverage 88.33% 89.92% +1.59%
==========================================
Files 61 58 -3
Lines 4054 3900 -154
Branches 815 780 -35
==========================================
- Hits 3581 3507 -74
+ Misses 430 346 -84
- Partials 43 47 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Updates the OPERATOR_KEY_MAIN environment variable storage to use a masked value.
Related Issues:
Fixes: #3011