Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add maxAttempts parameter to the acceptance test workflow #3089

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

beeradb
Copy link
Collaborator

@beeradb beeradb commented Oct 11, 2024

Fixes #3091

This PR makes the following changes:

  • Adds a maxAttempts parameter to the acceptance test workflow, so that we can control the number of test retry attempts.
  • Updates the public acceptance workflow to set the maxAtempts parameter to 1, ensuring we only do a single acceptance test run against public networks.

Signed-off-by: beeradb <294617+beeradb@users.noreply.github.com>
@beeradb beeradb added the enhancement New feature or request label Oct 11, 2024
@beeradb beeradb added this to the 0.58.0 milestone Oct 11, 2024
@beeradb beeradb self-assigned this Oct 11, 2024
@beeradb beeradb requested review from AlfredoG87, ebadiere, Nana-EC and a team as code owners October 11, 2024 15:03
Copy link

Copy link

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 25,159.6 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.46 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: decreased with 348.16 KB
  • Total Available Size: increased with 3.39 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 64.00 bytes
  • Used Heap Size: decreased with 3.43 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:

    • Space Size: increased with 1.84 MB
    • Space Used Size: increased with 2.08 MB
    • Space Available Size: increased with 42.62 KB
    • Physical Space Size: increased with 1.84 MB
  • Large Object Space:

    • Space Size: increased with 835.58 KB
    • Space Used Size: increased with 813.50 KB
    • Space Available Size: no changes
    • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

@beeradb beeradb changed the title add maxAttempts parameter to the acceptance test workflow feat: add maxAttempts parameter to the acceptance test workflow Oct 11, 2024
Copy link

Tests

       3 files     398 suites   18s ⏱️
1 428 tests 1 427 ✔️ 1 💤 0
1 437 runs  1 436 ✔️ 1 💤 0

Results for commit 7184126.

Copy link

Acceptance Tests

  20 files  307 suites   32m 21s ⏱️
601 tests 592 ✔️ 4 💤 5
853 runs  840 ✔️ 6 💤 7

Results for commit 7184126.

Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@beeradb beeradb merged commit afc3349 into main Oct 11, 2024
48 of 55 checks passed
@beeradb beeradb deleted the retries-as-parameter branch October 11, 2024 18:55
Copy link

@tomzhenghedera tomzhenghedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@quiet-node quiet-node added github_action and removed enhancement New feature or request labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (2e2fc07) to head (7184126).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3089      +/-   ##
==========================================
+ Coverage   82.05%   82.53%   +0.48%     
==========================================
  Files          64       66       +2     
  Lines        4223     4392     +169     
  Branches      844      868      +24     
==========================================
+ Hits         3465     3625     +160     
- Misses        513      516       +3     
- Partials      245      251       +6     
Flag Coverage Δ
relay 85.58% <ø> (+0.63%) ⬆️
server 83.43% <ø> (ø)
ws-server 33.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameter to acceptance tests to control the maximum number of retries
4 participants