-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add maxAttempts parameter to the acceptance test workflow #3089
Conversation
Signed-off-by: beeradb <294617+beeradb@users.noreply.github.com>
|
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3089 +/- ##
==========================================
+ Coverage 82.05% 82.53% +0.48%
==========================================
Files 64 66 +2
Lines 4223 4392 +169
Branches 844 868 +24
==========================================
+ Hits 3465 3625 +160
- Misses 513 516 +3
- Partials 245 251 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fixes #3091
This PR makes the following changes:
maxAttempts
parameter to the acceptance test workflow, so that we can control the number of test retry attempts.