Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick feat: added DEPENDENT_SERVICE_IMMATURE_RECORDS predefined error for immature records scenarios (#3394) #3415

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

quiet-node
Copy link
Member

Description:
This PR cherry picks feat: added DEPENDENT_SERVICE_IMMATURE_RECORDS predefined error for immature records scenarios into release/0.64

Related issue(s):

Fixes #3392

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…mmature records scenarios (#3394)

* feat: added DEPENDENT_SERVICE_IMMATURE_RECORDS predefined error for immature records scenarios

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>

* test: fixed unit tests for the new DEPENDENT_SERVICE_IMMATURE_RECORDS scenarios

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>

---------

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node added the process Build, test and deployment-process related tasks label Jan 22, 2025
@quiet-node quiet-node added this to the 0.64.1 milestone Jan 22, 2025
@quiet-node quiet-node self-assigned this Jan 22, 2025
@quiet-node quiet-node requested review from Nana-EC and a team as code owners January 22, 2025 16:18
Copy link

github-actions bot commented Jan 22, 2025

Test Results

 19 files  ± 0  274 suites  +14   33m 32s ⏱️ -5s
612 tests ± 0  607 ✅ ± 0  4 💤 ±0  1 ❌ ±0 
664 runs   - 77  659 ✅  - 77  4 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 319ce8c. ± Comparison against base commit 18d3acd.

♻️ This comment has been updated with latest results.

@Ferparishuertas Ferparishuertas self-requested a review January 22, 2025 21:20
Copy link

@Ferparishuertas Ferparishuertas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@quiet-node quiet-node merged commit 87f6955 into release/0.64 Jan 23, 2025
48 of 50 checks passed
@quiet-node quiet-node deleted the cherry-pick-3394 branch January 23, 2025 04:44
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.88%. Comparing base (18d3acd) to head (319ce8c).
Report is 1 commits behind head on release/0.64.

Files with missing lines Patch % Lines
packages/relay/src/lib/clients/mirrorNodeClient.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.64    #3415      +/-   ##
================================================
- Coverage         85.15%   84.88%   -0.27%     
================================================
  Files                69       69              
  Lines              4742     4738       -4     
  Branches           1067     1066       -1     
================================================
- Hits               4038     4022      -16     
- Misses              382      401      +19     
+ Partials            322      315       -7     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 79.56% <77.77%> (-0.01%) ⬇️
server 83.30% <100.00%> (+0.02%) ⬆️
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/errors/JsonRpcError.ts 74.50% <ø> (ø)
packages/relay/src/lib/eth.ts 86.11% <ø> (-0.44%) ⬇️
.../lib/services/ethService/ethCommonService/index.ts 91.30% <100.00%> (+1.09%) ⬆️
...ver/src/koaJsonRpc/lib/HttpStatusCodeAndMessage.ts 100.00% <100.00%> (ø)
packages/relay/src/lib/clients/mirrorNodeClient.ts 88.31% <75.00%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants