Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick PR#3422 feat(logging): enhanced logging upon receiving responses from the Mirror Node server (#3422) to release/0.64 #3426

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Jan 27, 2025

Description:
This PR cherry picked #3422 to release/0.64

Related issue(s):

Fixes #3421

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…rror Node server (#3422)

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node requested review from a team as code owners January 27, 2025 15:39
@quiet-node quiet-node requested a review from simzzz January 27, 2025 15:39
@quiet-node quiet-node self-assigned this Jan 27, 2025
@quiet-node quiet-node added the process Build, test and deployment-process related tasks label Jan 27, 2025
@quiet-node quiet-node added this to the 0.64.2 milestone Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Test Results

 19 files  + 19  257 suites  +257   38m 40s ⏱️ + 38m 40s
612 tests +612  607 ✅ +607  4 💤 +4  1 ❌ +1 
666 runs  +666  661 ✅ +661  4 💤 +4  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 948696d. ± Comparison against base commit 6bd832c.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node merged commit c7f3287 into release/0.64 Jan 27, 2025
49 of 52 checks passed
@quiet-node quiet-node deleted the cherry-pick-#3422 branch January 27, 2025 16:28
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (87f6955) to head (948696d).
Report is 2 commits behind head on release/0.64.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.64    #3426      +/-   ##
================================================
+ Coverage         83.11%   85.16%   +2.04%     
================================================
  Files                69       69              
  Lines              4738     4738              
  Branches           1066     1066              
================================================
+ Hits               3938     4035      +97     
+ Misses              457      383      -74     
+ Partials            343      320      -23     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 79.56% <0.00%> (ø)
server 83.30% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts 88.31% <100.00%> (ø)

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants