-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed eth_getCode to now use blockNumber when address is an HTS token #3433
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Test Results 20 files - 2 292 suites +21 38m 53s ⏱️ - 26m 50s For more details on these failures, see this check. Results for commit 004b072. ± Comparison against base commit 373f1dc. This pull request removes 4 and adds 10 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3433 +/- ##
==========================================
+ Coverage 85.20% 85.45% +0.25%
==========================================
Files 69 69
Lines 4711 4724 +13
Branches 1048 1052 +4
==========================================
+ Hits 4014 4037 +23
+ Misses 397 391 -6
+ Partials 300 296 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
If we pass an HTS token address to getCode, we do not take into account the block number, resulting in a bug where it would return the smart contract code even if the block number provided is earlier than the one where the token was created.
Related issue(s):
Fixes #3155
Notes for reviewer:
Checklist