chore: cherry pick feat: transaction with CONTRACT_NEGATIVE_VALUE breaks some routes (#3387) to release/0.64 #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanasow
requested review from
Nana-EC,
a team,
georgi-l95 and
Ivo-Yankov
as code owners
quiet-node
previously approved these changes
Jan 31, 2025
nadezhdapopovaa
previously approved these changes
Jan 31, 2025
quiet-node
force-pushed
the
cherry-pick-3387
branch
from
8bc3991 to
ba15b0a
Compare
Test Results 22 files - 1 323 suites +35 49m 33s ⏱️ - 18m 28s For more details on these failures, see this check. Results for commit ede1ea8. ± Comparison against base commit 5f9c2a4. ♻️ This comment has been updated with latest results. |
quiet-node
dismissed stale reviews from nadezhdapopovaa and themself
via
e459dd5
…3387) * chore: handle contract negative value calls Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: remove .only Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: fix comments Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: edit imports Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: resolving comments Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: fix json parsing Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: add e2e test Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: fix test Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: fix test Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: fix flaky test Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: tests Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: try to disable the test Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: add test Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: resolve comments Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: simplify the tests Signed-off-by: nikolay <n.atanasow94@gmail.com> --------- Signed-off-by: nikolay <n.atanasow94@gmail.com> Revert "feat: transaction with `CONTRACT_NEGATIVE_VALUE` breaks some routes (#3387)" This reverts commit 8bc3991. Reapply "feat: transaction with `CONTRACT_NEGATIVE_VALUE` breaks some routes (#3387)" This reverts commit 8d52b9a07a43cecd6241eaa9a7f2e65c4df8d4e5. Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
cherry-pick-3387
branch
from
e459dd5 to
b0de948
Compare
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
|
quiet-node
approved these changes
Jan 31, 2025
nadezhdapopovaa
approved these changes
Jan 31, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.64 #3436 +/- ##
================================================
+ Coverage 85.01% 85.16% +0.15%
================================================
Files 69 69
Lines 4765 4780 +15
Branches 1074 1077 +3
================================================
+ Hits 4051 4071 +20
- Misses 398 399 +1
+ Partials 316 310 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
cherry pick feat: transaction with CONTRACT_NEGATIVE_VALUE breaks some routes (#3387) to release/0.64 #3436
Related issue(s):
Fixes #3367
Notes for reviewer:
Checklist