-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang.org/x/net to v0.34.0 #2017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
@here Can we fix and merge this early? |
I tried to fix the lint errors. |
Linting succeeds now but we get another (ephemeral ?)
Any hints? |
@eualin thank you for your patience on that PR, I pinged the team to take a look into this. Looks like the CI test-case calling vault is having a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The test cases have been flaky for a while. I've kept a note of it and will check it later.
@sreeram77 What is the release process and when can we expect new TAG with this change? |
Hi @sreeram77 could you have a look at this PR #1905 as well ? It will be nice to get a comment from the team if the change will be merged or no. Thanks |
Bumps the
golang.org/x/net
package to mitigate theCVE-2024-45338
vulnerability.