Made nested query resources replace the whole resource instead of merging new over old #21721
+80
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ging new over old (hashicorp#13234) [upstream:2ba1acd7e865dce04fe3d0b4c1b136cbdb2f93e2] Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows fields to be unset using the same logic that any other field on any other resource would use.
Related to #14848
b/394945456#comment14
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Note: Technically this also allows
nat_ip_allocate_optionto be unset, but that field must be set for type = PUBLIC and can't be set for type = PRIVATE, and modifyingtypeforces recreation, so there doesn't seem to be a case where it can actually be unset on update.This doesn't impact
google_compute_router_natbecause the only optional field has send_empty_value set.Derived from GoogleCloudPlatform/magic-modules#13234