Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3077: Make actorType and origin a required entity provenance #6272

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

It should always be possible to specify these

🚫 Blocked by

We need to migrate the production database first:

🔍 What does this change?

  • Make the provenance fields required in the graph
  • Adjust TS to always pass the fields
  • Remove redundant types we previously used to enforce it because the graph is now properly exposing these types.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@TimDiekmann TimDiekmann requested a review from CiaranMn January 28, 2025 10:19
@TimDiekmann TimDiekmann self-assigned this Jan 28, 2025
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/blocks Relates to first-party blocks (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/tests New or updated tests area/apps labels Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 20.76%. Comparing base (bdb1b73) to head (e354ed2).

Files with missing lines Patch % Lines
...system-graph-is-initialized/provenance-defaults.ts 0.00% 6 Missing ⚠️
...hash-api/src/graph/ontology/primitive/data-type.ts 0.00% 6 Missing ⚠️
...-api/src/graph/ontology/primitive/property-type.ts 0.00% 5 Missing ⚠️
...sh-api/src/graph/ontology/primitive/entity-type.ts 0.00% 3 Missing ⚠️
...-activities/infer-metadata-from-document-action.ts 0.00% 1 Missing ⚠️
...ctivities/flow-activities/persist-flow-activity.ts 0.00% 1 Missing ⚠️
...vities/flow-activities/research-entities-action.ts 0.00% 1 Missing ⚠️
...earch-entities-action/shared/deduplicate-claims.ts 0.00% 1 Missing ⚠️
...w-activities/shared/create-file-entity-from-url.ts 0.00% 1 Missing ⚠️
...s-from-text/infer-entity-claims-from-text-agent.ts 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@                           Coverage Diff                            @@
##           cm/type-icon-plural-datatype-updates    #6272      +/-   ##
========================================================================
- Coverage                                 20.76%   20.76%   -0.01%     
========================================================================
  Files                                       585      585              
  Lines                                     20079    20080       +1     
  Branches                                   2981     2981              
========================================================================
  Hits                                       4169     4169              
- Misses                                    15858    15859       +1     
  Partials                                     52       52              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.30% <0.00%> (-0.01%) ⬇️
apps.hash-api 1.13% <0.00%> (ø)
local.hash-backend-utils 8.81% <0.00%> (ø)
local.hash-graph-sdk 58.62% <ø> (ø)
local.hash-isomorphic-utils 0.89% <ø> (ø)
local.hash-subgraph 24.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimDiekmann TimDiekmann force-pushed the t/h-3077-make-actortype-and-origin-a-required-entity-provenance branch from 2a66e7c to e354ed2 Compare February 16, 2025 17:53
@github-actions github-actions bot added area/infra Relates to version control, CI, CD or IaC (area) area/tests > playwright New or updated Playwright tests labels Feb 16, 2025
@TimDiekmann TimDiekmann changed the base branch from main to cm/type-icon-plural-datatype-updates February 16, 2025 17:54
@TimDiekmann TimDiekmann merged commit e354ed2 into cm/type-icon-plural-datatype-updates Feb 16, 2025
79 of 87 checks passed
@TimDiekmann TimDiekmann deleted the t/h-3077-make-actortype-and-origin-a-required-entity-provenance branch February 16, 2025 17:55
@TimDiekmann TimDiekmann restored the t/h-3077-make-actortype-and-origin-a-required-entity-provenance branch February 16, 2025 17:57
@vercel vercel bot temporarily deployed to Preview – hashdotdev February 16, 2025 18:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/blocks Relates to first-party blocks (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests > playwright New or updated Playwright tests area/tests New or updated tests type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

2 participants