Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
nextPermutation
like 10 times faster, resolving theTODO
from 2014:Let's do it!
Edit:
stToPrim
(suggested by @gksato) makes it even faster. WithstToPrim
, the bangs are not needed for the speed, but I preferred explicit strict evaluation.If anyone is interested, here's my AtCoder submissions for a simple speed comparsion:
GM.nextPermutation
: time limit exceedGM.nextPermutation
with tuples unboxed: accepted (281 ms in the worst case)GM.nextPermutation
withstToPrim
and with tuples unboxed: accepted (231 ms in the worst case)