-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Applicative based API #522
Draft
Shimuuar
wants to merge
4
commits into
master
Choose a base branch
from
traverse
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+183
−4
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3764a73
Implement functions which use Applicatives
Shimuuar 56dbd80
First version of benchmarks for applicative functions
Shimuuar bb38bf5
Implement STA optimization trick as an optimization
Shimuuar 6ad3458
Update vector/src/Data/Vector/Generic.hs
Shimuuar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
{-# LANGUAGE RankNTypes #-} | ||
{-# LANGUAGE ScopedTypeVariables #-} | ||
-- | | ||
-- This module provides benchmarks for functions which use API based | ||
-- on applicative. We use @generateA@ based benchmark for state and IO | ||
-- and also benchmark folds and mapping using lens since it's one of | ||
-- important consumers of this API. | ||
module Bench.Vector.Algo.Applicative | ||
( -- * Standard benchmarks | ||
generateState | ||
, generateStateUnfold | ||
, generateIO | ||
, generateIOPrim | ||
-- * Lens benchmarks | ||
, lensSum | ||
, baselineSum | ||
, lensMap | ||
, baselineMap | ||
) where | ||
|
||
import Control.Applicative | ||
import Data.Coerce | ||
import Data.Functor.Identity | ||
import Data.Int | ||
import Data.Monoid | ||
import Data.Word | ||
import qualified Data.Vector.Generic as VG | ||
import qualified Data.Vector.Generic.Mutable as MVG | ||
import qualified Data.Vector.Unboxed as VU | ||
import System.Random.Stateful | ||
import System.Mem (getAllocationCounter) | ||
|
||
-- | Benchmark which is running in state monad. | ||
generateState :: Int -> VU.Vector Word64 | ||
generateState n | ||
= runStateGen_ (mkStdGen 42) | ||
$ \g -> VG.generateA n (\_ -> uniformM g) | ||
|
||
-- | Benchmark which is running in state monad. | ||
generateStateUnfold :: Int -> VU.Vector Word64 | ||
generateStateUnfold n = VU.unfoldrExactN n genWord64 (mkStdGen 42) | ||
|
||
-- | Benchmark for running @generateA@ in IO monad. | ||
generateIO :: Int -> IO (VU.Vector Int64) | ||
generateIO n = VG.generateA n (\_ -> getAllocationCounter) | ||
|
||
-- | Baseline for 'generateIO' it uses primitive operations | ||
generateIOPrim :: Int -> IO (VU.Vector Int64) | ||
generateIOPrim n = VG.unsafeFreeze =<< MVG.replicateM n getAllocationCounter | ||
|
||
-- | Sum using lens | ||
lensSum :: VU.Vector Double -> Double | ||
{-# NOINLINE lensSum #-} | ||
lensSum = foldlOf' VG.traverse (+) 0 | ||
|
||
-- | Baseline for sum. | ||
baselineSum :: VU.Vector Double -> Double | ||
{-# NOINLINE baselineSum #-} | ||
baselineSum = VU.sum | ||
|
||
-- | Mapping over vector elements using | ||
lensMap :: VU.Vector Double -> VU.Vector Double | ||
{-# NOINLINE lensMap #-} | ||
lensMap = over VG.traverse (*2) | ||
|
||
-- | Baseline for map | ||
baselineMap :: VU.Vector Double -> VU.Vector Double | ||
{-# NOINLINE baselineMap #-} | ||
baselineMap = VU.map (*2) | ||
|
||
---------------------------------------------------------------- | ||
-- Bits and pieces of lens | ||
-- | ||
-- We don't want to depend on lens so we just copy relevant | ||
-- parts. After all we don't need much | ||
---------------------------------------------------------------- | ||
|
||
type ASetter s t a b = (a -> Identity b) -> s -> Identity t | ||
type Getting r s a = (a -> Const r a) -> s -> Const r s | ||
|
||
foldlOf' :: Getting (Endo (Endo r)) s a -> (r -> a -> r) -> r -> s -> r | ||
foldlOf' l f z0 = \xs -> | ||
let f' x (Endo k) = Endo $ \z -> k $! f z x | ||
in foldrOf l f' (Endo id) xs `appEndo` z0 | ||
{-# INLINE foldlOf' #-} | ||
|
||
foldrOf :: Getting (Endo r) s a -> (a -> r -> r) -> r -> s -> r | ||
foldrOf l f z = flip appEndo z . foldMapOf l (Endo #. f) | ||
{-# INLINE foldrOf #-} | ||
|
||
foldMapOf :: Getting r s a -> (a -> r) -> s -> r | ||
foldMapOf = coerce | ||
{-# INLINE foldMapOf #-} | ||
|
||
( #. ) :: Coercible c b => (b -> c) -> (a -> b) -> (a -> c) | ||
( #. ) _ = coerce (\x -> x :: b) :: forall a b. Coercible b a => a -> b | ||
{-# INLINE (#.) #-} | ||
|
||
over :: ASetter s t a b -> (a -> b) -> s -> t | ||
over = coerce | ||
{-# INLINE over #-} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably better to use
liftA2
here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. But I'm not sure that
STA
will survive maybe someNew
-like variant will perform better