Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses #198 Exclude items with pd rights from bib_newyear.pl #200

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Addresses #198 Exclude items with pd rights from bib_newyear.pl #200

merged 2 commits into from
Jan 22, 2025

Conversation

moseshll
Copy link
Collaborator

@moseshll moseshll commented Jan 20, 2025 •
edited
Loading

  • Remove all pd rights from the big old SQL query that kicks off the script.

See #198 referencing DEV-1033 comment

My suggestion is to exclude everything already at a “pd” attribute from reversion to bib. We would gain nothing in terms of access by reverting pd/ren, pd/crms, and pd/ncn items to pd/bib and we would lose stability of openness for some items.

Reviewer: this should merit only a quick eyeball.

@moseshll
Addresses #198 Exclude items with pd rights from bib_newyear.pl
611b165 
- Remove all pd rights from the big old SQL query that kicks off the script.
@moseshll moseshll requested a review from mwarin January 20, 2025 22:12
mwarin
mwarin approved these changes Jan 22, 2025
View reviewed changes
Copy link

@mwarin mwarin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. No pd/* remaining, which was the goal specified in the description.

bin/bib_newyear.pl Outdated Show resolved Hide resolved
@moseshll moseshll requested a review from mwarin January 22, 2025 17:19
mwarin
mwarin approved these changes Jan 22, 2025
View reviewed changes
Copy link

@mwarin mwarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 👍
Approve.

@moseshll moseshll merged commit d5bcfdf into main Jan 22, 2025
1 check passed
@moseshll moseshll deleted the 198_exclude_pd_from_bib_newyear branch January 22, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwarin mwarin mwarin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moseshll @mwarin