DEV-1440 - write journal when indexing full file #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelkiss
commented
Dec 11, 2024
| # "since" command for a month starts on the last day of last month | ||
| # because there will generally be both an "upd" and a "full" file. | ||
| call_since_command last_full_marc_file.to_datetime | ||
| logger.info "Commit" |
There was a problem hiding this comment.
The individual date commands commit, so we don't need to commit again afterwards (although it doesn't hurt)
aelkiss
commented
Dec 11, 2024
| # Calling the Thor "file" command. | ||
| call_file_command file | ||
|
|
||
| logger.info "Commit" |
There was a problem hiding this comment.
Before, we were committing after loading deleted records, but not after we loaded the full file. We probably want to commit after we load the full file.
aelkiss
commented
Dec 11, 2024
lib/services.rb
Outdated
| @@ -104,4 +104,6 @@ def env_local_file | |||
| Services.register(:collection_map) do | |||
| CICTL::CollectionMap.new.to_translation_map | |||
| end | |||
|
|
|||
| Services.register(:job_name) { ENV.fetch("JOB_NAME",$PROGRAM_NAME) } | |||
There was a problem hiding this comment.
Without a default, running individual specs fails in inscrutable ways.
moseshll
approved these changes
Dec 11, 2024
We were checking for a full journal file but not writing one when we did the full index, leading to a situation where regardless of journal file presence the "continue" command would do a full reindex every day.
aelkiss
force-pushed
the
DEV-1440-full-journal
branch
from
68e2169 to
23e34e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking for a full journal file but not writing one when we did the full index, leading to a situation where regardless of journal file presence the "continue" command would do a full reindex every day.
This refactors the
allcommand some, and tests that we are writing both the full and update journal files.