DEV-973: check correct journal file for continue #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelkiss
commented
Dec 13, 2024
| it "indexes it and writes the journal" do | ||
| latest_examples = CICTL::Examples.of_type(:upd, :delete).select { |e| e[:date] == "20230103" } | ||
|
|
||
| CICTL::Examples.of_type(:full, :upd) |
There was a problem hiding this comment.
no journals for delete examples
Merged
mwarin
approved these changes
Dec 16, 2024
| @@ -15,6 +15,15 @@ def metrics? | |||
| metrics.match?(/^job_records_processed\S*job="#{job_name}"\S* \S+/m) | |||
| end | |||
|
|
|||
| # records may be updated multiple times, so we need to dedupe those | |||
| def unique_id_count(examples) | |||
There was a problem hiding this comment.
I think the new unique_id_count could also be used on line 145:
- expect(solr_count).to eq examples.map { |ex| ex[:ids] }.flatten.uniq.count
+ expect(solr_count).to eq unique_id_count(examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cictl index continuewas checking only that the full journal existed (and checking that multiple times)... This should correct the observed behavior where it is not indexing additional daily files after doing the full run.