Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added previous work done with Lianet, added deploy action, updated b… #65

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

Ronster2018
Copy link
Contributor

…uild action

@coveralls
Copy link

coveralls commented Dec 16, 2024

Coverage Status

coverage: 92.483%. remained the same
when pulling d9f7170 on DEV-1397
into f73dca4 on main.

@aelkiss aelkiss changed the title Added previous work done with lianete, added deploy action, updated b… Added previous work done with Lianet, added deploy action, updated b… Dec 16, 2024
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good; it might be nice to have different name keys in build-solr.yaml, but not critical.

registry_token: ${{ github.token }}
rebuild: ${{ inputs.rebuild }}
build-args: "--target indexer"
- name: Build Solr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably would be useful to change this to something like "Build Solr (Sample Index)" rather than have the same name for both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. That has been updated.

Changed Build Name to `Build Solr (Sample Index)`
@Ronster2018 Ronster2018 merged commit 8c84b22 into main Dec 17, 2024
1 check passed
@Ronster2018 Ronster2018 deleted the DEV-1397 branch December 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants