Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-1475 catalog indexing: update what env vars it uses for the database #76

Merged
merged 1 commit into from
Jan 24, 2025
Merged

DEV-1475 catalog indexing: update what env vars it uses for the database #76

merged 1 commit into from
Jan 24, 2025

Conversation

moseshll
Copy link
Contributor

  • Change connection string to use new ENV names
    • Add note about connection string being the anointed method for JDBC connections in Sequel (alas)
  • Remove NO_DB env in docker compose so we exercise the DB connection a bit in our tests

@moseshll
DEV-1475 catalog indexing: update what env vars it uses for the database
b4b0787 
- Change connection string to use new ENV names
  - Add note about connection string being the anointed method for JDBC connections in Sequel (alas)
- Remove `NO_DB` env in docker compose so we exercise the DB connection a bit in our tests
@moseshll moseshll requested a review from aelkiss January 20, 2025 21:20
@coveralls
Copy link

Coverage Status

coverage: 92.353%. remained the same
when pulling b4b0787 on DEV-1475_db_credentials_from_ENV
into bb84f32 on main.

aelkiss
aelkiss approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, with the same caveat about getting the updates in tanka deployed first.

@aelkiss aelkiss merged commit 0384328 into main Jan 24, 2025
1 check passed
@aelkiss aelkiss deleted the DEV-1475_db_credentials_from_ENV branch January 24, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelkiss aelkiss aelkiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moseshll @coveralls @aelkiss